More information about the Underscore mailing list

[_] feedback request

Jon Bennett jmbennett at gmail.com
Wed Dec 6 08:47:04 GMT 2006

Morning Alex,

> If anyone would like to give feedback on my site I'd be grateful:
> http://www.lightenna.com/

recent work doesn't validate :( shouldn't be hard to fix though

I think you could/should use slightly less divs, consider this chunk of code:

<div class="item-list">
	<ul>
		<li>
			<div class='view-item view-item-news-view'>
				<div class='view-field view-data-node-title'><a
href="/news/company_update/it_work_grants_still_available">£500
IT at work grants available</a></div>
				<div class='view-field view-data-node-changed'>December</div>
			</div>
		</li>
	</ul>
</div>

This could be changed to:

<ul class="item-list">
	<li class='view-item view-item-news-view'>
		<a class='view-field
view-data-node-title'href="/news/company_update/it_work_grants_still_available">£500
IT at work grants available</a>
		<em class='view-field view-data-node-changed'>December</em>
	</li>
</ul>

I would have thought though that you could loose the classes from the
href and em above, instead letting them flow from the CSS, eg:

ul.item-list {
	
}
ul.item-list li {
	
}
ul.item-list li a
{
	
}
ul.item-list li em {
	
}

this would make your html nice and clean, ala:

<ul class="item-list">
	<li>
		<a href="/news/company_update/it_work_grants_still_available">£500
IT at work grants available</a>
		<em>December</em>
	</li>
</ul>

hth

jon
ps: I have my developer, not designer head on this morning, hence no
comments on the visual aspects of your site!

-- 


jon bennett
t: +44 (0) 1225 341 039 w: http://www.jben.net/
iChat (AIM): jbendotnet Skype: jon-bennett