[_] div height issue with firefox
Tim Beadle
tim.beadle at gmail.com
Wed Aug 2 10:14:02 BST 2006
On 02/08/06, jean-paul at firecast.co.uk <jean-paul at firecast.co.uk> wrote:
> Sure try this url
> http://www.fge-mobilephones.com/fge_test/fge_2006/show_products.php?category_id=47&menu=Mobile_Phones
>
> It's a test version of the site so not exactly polished but you can see
> the issue that I was talking about with the list of items on this page.
I hate to be a validation fascist, but you'll have a better chance of
a working layout when the HTML is fixed:
http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.fge-mobilephones.com%2Ffge_test%2Ffge_2006%2Fshow_products.php%3Fcategory_id%3D47%26menu%3DMobile_Phones
Your CSS has some unit-less lengths (e.g. "margin-left: 5") as well:
http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http%3A%2F%2Fwww.fge-mobilephones.com%2Ffge_test%2Ffge_2006%2Fcss%2Ffge.css
Incidentally, I thought that using underscores in class or ID names
was bad form. Seems to validate OK, though.
Lots of your classes represent things that will only happen once on a
page (e.g. your *_wrapper classes) so they're better off as IDs.
Tim
> Sure try this url
> http://www.fge-mobilephones.com/fge_test/fge_2006/show_products.php?category_id=47&menu=Mobile_Phones
>
> It's a test version of the site so not exactly polished but you can see
> the issue that I was talking about with the list of items on this page.
I hate to be a validation fascist, but you'll have a better chance of
a working layout when the HTML is fixed:
http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.fge-mobilephones.com%2Ffge_test%2Ffge_2006%2Fshow_products.php%3Fcategory_id%3D47%26menu%3DMobile_Phones
Your CSS has some unit-less lengths (e.g. "margin-left: 5") as well:
http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http%3A%2F%2Fwww.fge-mobilephones.com%2Ffge_test%2Ffge_2006%2Fcss%2Ffge.css
Incidentally, I thought that using underscores in class or ID names
was bad form. Seems to validate OK, though.
Lots of your classes represent things that will only happen once on a
page (e.g. your *_wrapper classes) so they're better off as IDs.
Tim